Fix not reported when log from not main thread #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuniwak
force-pushed
the
stop-when-error-immediately-thrown
branch
from
f27dc9e to
3e9deab
Compare
Kuniwak
force-pushed
the
stop-when-error-immediately-thrown
branch
3 times, most recently
from
049f935 to
9af66be
Compare
Reproducing steps: 1. Stay keep state not playing 2. Open the scene "Error" 3. Open an inspector for "AutopilotSettingsForFacingImmediatelyError" 4. Click Run Expected Behaviour: Stop playing and report the error to Slack. Actual Behaviour: Still playing and did not report to Slack.
Kuniwak
force-pushed
the
catch-from-not-main-thread
branch
from
4c0c018 to
b573d0a
Compare
asurato
previously approved these changes
Nov 14, 2023
Base automatically changed from
stop-when-error-immediately-thrown
to
master
November 14, 2023 05:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducing steps
Expected Behaviour
Stop playing and report the error to Slack.
Actual Behaviour
Still playing and did not report to Slack.
Contribution License Agreement