Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile #91

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix Makefile #91

merged 2 commits into from
Oct 31, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Add task test_standalone_player; Run Play Mode tests on standalone player.
  • Add install test-helper package required in tests

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 30, 2024 18:45
@github-actions github-actions bot added the chore label Oct 30, 2024
@get-me-power get-me-power self-requested a review October 31, 2024 05:48
get-me-power
get-me-power approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power get-me-power merged commit ccfdc03 into DeNA:master Oct 31, 2024
2 checks passed
@nowsprinting nowsprinting deleted the chore/makefile branch October 31, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@get-me-power get-me-power get-me-power approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @get-me-power