Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to node20 #142

Merged
merged 2 commits into from
Jul 27, 2024
Merged

update to node20 #142

merged 2 commits into from
Jul 27, 2024

Conversation

srz-zumix
Copy link
Collaborator

@srz-zumix srz-zumix commented May 13, 2024 •
edited
Loading

Description

update to node20 action.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: 
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Related issue:

Contributor License Agreements

@srz-zumix srz-zumix added the BREAKING CHANGES Semver major fix label May 13, 2024
@srz-zumix srz-zumix requested a review from Kesin11 as a code owner May 13, 2024 07:06
@Kesin11
Copy link
Collaborator

Kesin11 commented May 13, 2024

@srz-zumix
It's time to update node20! 🎉
However, we need to update not only action.yml but also other code that uses node16.
https://github.com/search?q=repo%3ADeNA%2Fsetup-job-workspace-action%2016&type=code

And I pinned @actions/github a long time ago #13. If after fix test workflow and test fails, @actions/github may need to be updated at the same time.

@Kesin11
Copy link
Collaborator

Kesin11 commented May 13, 2024

And also need to update README fixing DeNA/setup-job-workspace-action@v2 to v3 if you release soon after merge.

Kesin11
Kesin11 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@Kesin11 Kesin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Kesin11 Kesin11 merged commit f58807e into main Jul 27, 2024
14 checks passed
@Kesin11 Kesin11 deleted the feature/update_to_node20 branch July 27, 2024 13:15
@Kesin11
Copy link
Collaborator

Kesin11 commented Jul 27, 2024

@srz-zumix
Thx!
Please release it when you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kesin11 Kesin11 Kesin11 approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGES Semver major fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srz-zumix @Kesin11