Skip to content

Commit

Permalink
Fix parameter parsing in EngineArgs
Browse files Browse the repository at this point in the history
  • Loading branch information
DearPlanet committed Apr 9, 2024
1 parent 9ad067d commit c6adebc
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion vllm/engine/arg_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,14 @@ def from_cli_args(cls, args: argparse.Namespace) -> 'EngineArgs':
# Get the list of attributes of this dataclass.
attrs = [attr.name for attr in dataclasses.fields(cls)]
# Set the attributes from the parsed arguments.
engine_args = cls(**{attr: getattr(args, attr) for attr in attrs})
engine_args = cls(**{
attr: getattr(args, attr)
for attr in attrs if hasattr(args, attr)
})
if hasattr(args, "served_model_name"):
engine_args.served_model_name = args.served_model_name
else:
engine_args.served_model_name = args.model
return engine_args

def create_engine_config(self, ) -> EngineConfig:
Expand Down

0 comments on commit c6adebc

Please sign in to comment.