Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 1039 improve recipe explanation #1404

Merged
merged 23 commits into from
Aug 28, 2023
Merged

Feature/sg 1039 improve recipe explanation #1404

merged 23 commits into from
Aug 28, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Aug 23, 2023 •
edited
Loading

This PR combines multiple Feedbacks that were raised.

Main highlights

  • Combining information configuration and Training_Recipes to make 4 tutorials, each with a clear purpose and context
  • Explaining more in-depth how recipes are structured
  • Explaining how to write AND run a custom recipe (for people who did not clone the repo)

@Louis-Dupont Louis-Dupont marked this pull request as ready for review August 23, 2023 11:30
eran-deci
eran-deci reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@eran-deci eran-deci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed and helpful guides!
just a few minor comments below

documentation/source/Recipes_Training.md Outdated Show resolved Hide resolved
documentation/source/Recipes_Training.md Outdated Show resolved Hide resolved
documentation/source/Recipes_Training.md Outdated Show resolved Hide resolved
documentation/source/Recipes_Custom.md Show resolved Hide resolved
documentation/source/Recipes_Custom.md Outdated Show resolved Hide resolved
documentation/source/Recipes_Custom.md Outdated Show resolved Hide resolved
@eran-deci
Copy link
Contributor

LGTM

BloodAxe
BloodAxe previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe
Copy link
Contributor

Great work here!

BloodAxe
BloodAxe approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit fd87ce0 into master Aug 28, 2023
@Louis-Dupont Louis-Dupont deleted the feature/SG-1039-improve_recipe_explanation branch August 28, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eran-deci eran-deci eran-deci left review comments

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Louis-Dupont @eran-deci @BloodAxe