Adding a deprecation option into registeries #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
…e register all the classes one at a time///
Louis-Dupont
force-pushed
the
feature/SG-1041-decide_on_naming_convention
branch
from
1ff5418 to
d996fa2
Compare
Louis-Dupont
changed the title
Louis-Dupont
requested review from
shaydeci,
ofrimasad and
BloodAxe
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Use the class names instead of custom snake_case format to name objects
What this PR includes
This PR introduces the logic to deprecate old snake_case names.
Check the unittest to better understand the logic.
Changing the registration names will be done in followup PRs for more clarity (you check out this PR #1446 which will introduce the first object renaming)