Enforced check of that all notebooks has matching SG version installed #1607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue with regex in checking version of SG package (Now both
pip install super-gradients
andpip install super_gradietns
commands are parsed correctly)It also simplify Makefile by splitting NOTEBOOKS variable into NOTEBOOKS_TO_CHECK and NOTEBOOKS_TO_RUN
These variables are no multi-line, which makes it easier to merge PRs where notebooks are added.
And lastly, now
check_notebooks_version_match
is a part of breaking change test to enforce our notebooks are up-to-date.