added find_detection_score_threshold #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaylevy-deci
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
BloodAxe
reviewed
May 16, 2023
shaydeci
suggested changes
May 16, 2023
There was a problem hiding this comment.
Very nice work!
- See one comment inline.
- There's still a missing piece we spoke of - we get the different thresholds per class, then we wish to use these in our NMS.
- It would also be great to just have the threshold that maximizes F1.
- Nice to have: same mechanism for the other metrics (mAP etc).
shaydeci
suggested changes
May 23, 2023
|
@itaylevy-deci This PR has been open for quite a while now and has some comments that were not addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computes the best threshold for each class in an efficient manner without added loops