Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in README.md #301

Merged
merged 2 commits into from
Oct 7, 2023
Merged

fix typos in README.md #301

merged 2 commits into from
Oct 7, 2023

Conversation

rahul0x00
Copy link
Contributor

Issue #

Changes Proposed

I found a few typos, these are minor suggestions to improve formatting and readability.

Explanation of Changes

  1. In the "Options" section, there's a small formatting issue with the last line of the usage text:
    Original: "-i, --info Info displays basic info of the scanned site` "
    Suggested Change: "-i, --info Info displays basic info of the scanned site"

  2. In the "Installation" section, there's a minor grammatical issue in the sentence: "The script install.sh will first install the latest version of torbot found in pypi,". You can make it more grammatically correct like this:
    Suggested Change: "The script install.sh will first install the latest version of torbot found on PyPI,"

  3. In the "Using Docker" section, there's a missing word in this sentence: "Ensure than you have a tor container running on port 9050." It should be "Ensure that you have a tor container running on port 9050."

  4. In the "References" section, there are some minor formatting issues with the citation numbers. For consistency, you can format them like this:
    Original: "1. M. Glassman and M. J. Kang, “Intelligence in the internet age..."
    Suggested Change: "1. M. Glassman and M. J. Kang, “Intelligence in the Internet age..."

Screenshots of new feature/change

I found a few typos, these are minor suggestions to improve formatting and readability.

    In the "Options" section, there's a small formatting issue with the last line of the usage text:
    Original: "-i, --info Info displays basic info of the scanned site` </pre>"
    Suggested Change: "-i, --info Info displays basic info of the scanned site</pre>"

    In the "Installation" section, there's a minor grammatical issue in the sentence: "The script install.sh will first install the latest version of torbot found in pypi,". You can make it more grammatically correct like this:
    Suggested Change: "The script install.sh will first install the latest version of torbot found on PyPI,"

    In the "Using Docker" section, there's a missing word in this sentence: "Ensure than you have a tor container running on port 9050." It should be "Ensure that you have a tor container running on port 9050."

    In the "Curated Features" section, there's a small formatting issue with the checklist:
    Original: "- [x] Visualization Module Revamp"
    Suggested Change: "- [x] Visualization Module Revamp"

    In the "References" section, there are some minor formatting issues with the citation numbers. For consistency, you can format them like this:
    Original: "1. M. Glassman and M. J. Kang, “Intelligence in the internet age..."
    Suggested Change: "1. M. Glassman and M. J. Kang, “Intelligence in the Internet age..."

    In the "Maintainers" section, you can remove the ellipsis (...) as it doesn't seem necessary in this context.
@rahul0x00 rahul0x00 changed the title Update README.md fix typos in README.md Oct 7, 2023
README.md Outdated Show resolved Hide resolved
Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good besides line 172. I'll approve and merge once that's updated.

Copy link
Contributor Author

@rahul0x00 rahul0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@rahul0x00 rahul0x00 requested a review from KingAkeem October 7, 2023 12:00
Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and thanks for the contribution

@KingAkeem KingAkeem merged commit 5666f14 into DedSecInside:dev Oct 7, 2023
@rahul0x00 rahul0x00 deleted the patch-1 branch October 7, 2023 12:19
@PSNAppz PSNAppz mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants