-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge url options #16
Conversation
4cabc1f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added suggestions for the README as a separate PR to this branch, check it out here
Also, can we add validation for the URL, instead of having a default to an external URL, let's disable the plugin if the URL is not present. We can do it in a separate PR
* feat: update readme * chore: update readme title Co-authored-by: James George <[email protected]> Co-authored-by: James George <[email protected]>
5bb869d
to
103de9d
Compare
Co-authored-by: Yash Dave <[email protected]>
103de9d
to
f3fd129
Compare
@shivam-deepsource PTAL. |
Description
This PR aims at unifying the development and production WebSocket connection URLs into a single option and other improvements.
Type of change
Changes in this PR
urlForDev
andurlForProd
options.url
option.websocket
key.websocket
->WebSocket
.Checklist before merging
Note to reviewers (Optional)
As suggested by @shivam-deepsource