Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parser for Talisman #7933

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Add parser for Talisman #7933

merged 1 commit into from
Apr 10, 2023

Conversation

iamnihal
Copy link
Contributor

@iamnihal iamnihal commented Apr 3, 2023

Description

This PR will add Talisman (https://github.com/thoughtworks/talisman) as a new scanner/importer.

Documentation

Documentation included in docs/content/en/integrations/parsers/file/talisman.md

Checklist

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.
  • Your code is flake8 compliant.
  • Your code is python 3.11 compliant.
  • If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
  • Add applicable tests to the unit tests.
  • Add the proper label to categorize your PR.

@iamnihal
Copy link
Contributor Author

iamnihal commented Apr 3, 2023

Issue #6512

@iamnihal
Copy link
Contributor Author

iamnihal commented Apr 5, 2023

Hi @Maffooch - Any guesses why the checks are getting failed? As I went through the logs, the reason is different from the first attempt.

@mtesauro
Copy link
Contributor

mtesauro commented Apr 6, 2023

You can force the test to re-run if you close and re-open this PR. Sometimes they just need another run.

@iamnihal iamnihal closed this Apr 7, 2023
@iamnihal iamnihal reopened this Apr 7, 2023
mtesauro
mtesauro approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

blakeaowens
blakeaowens approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@blakeaowens blakeaowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakeaowens blakeaowens merged commit b627270 into DefectDojo:dev Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeaowens blakeaowens blakeaowens approved these changes

@Maffooch Maffooch Maffooch approved these changes

@mtesauro mtesauro mtesauro approved these changes

@damiencarol damiencarol damiencarol approved these changes

Assignees
No one assigned
Labels
docs parser unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamnihal @mtesauro @damiencarol @Maffooch @blakeaowens