Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added PoolTogether V5 TVL #7828

Merged
merged 4 commits into from
Oct 25, 2023
Merged

feat: Added PoolTogether V5 TVL #7828

merged 4 commits into from
Oct 25, 2023

Conversation

Ncookiez
Copy link
Contributor

This PR adds TVL data for PoolTogether V5.

The implementation is in projects/pooltogether/v5.js.

I have split up the code for V3, V4 and V5 into separate files. index.js calls each of these files and adds the TVLs together.

The V3 and V4 code has been linted and cleaned up a bit, but otherwise no real changes were made to those.

Other Notes

  • I've removed a seemingly random pooltogether reference in the .gitignore. This was added a really long time ago for apparently no reason. Unsure why that was there.
  • I've added a couple more "hallmark" timestamps; the launch of V4 and the launch of V5.

@llamatester
Copy link

The adapter at projects/pooltogether exports TVL:

avax                      72.00 k
celo                      55.38 k
polygon                   2.34 M
optimism                  2.72 M
bsc                       3.14 k
ethereum                  3.68 M

total                    8.88 M 

@llamatester
Copy link

The adapter at projects/pooltogether exports TVL:

avax                      72.28 k
optimism                  2.69 M
celo                      55.07 k
polygon                   2.42 M
bsc                       3.11 k
ethereum                  3.85 M

total                    9.08 M 

@g1nt0ki
Copy link
Member

g1nt0ki commented Oct 25, 2023

@Ncookiez thanks for the changes, I have updated it a bit to use sdk-v4.x

would you prefer if we show tvl per version like we show for aave/uniswap or as it is now?

@g1nt0ki g1nt0ki merged commit decd07a into DefiLlama:main Oct 25, 2023
@Ncookiez
Copy link
Contributor Author

Thanks for the update! First time contributing to this repo, so wasn't sure exactly what patterns to use.

would you prefer if we show tvl per version like we show for aave/uniswap or as it is now?

I think it'd make sense to split it between versions! Is this something you can easily handle on your end or do you need me to set things up differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants