[Material UI] Fix AutoComplete props #13506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
material-ui/index.d.ts to authors (@ngbrown @herrmanno). Could you review this PR? Checklist
|
|
Please rebase onto the |
ghost
added
the
Revision needed
…mNavigationItem icon and label props to be react nodes.
…g allows it to be configurable.
|
@andy-ms Done 😄 |
ghost
reviewed
Dec 28, 2016
| @@ -561,7 +559,7 @@ declare namespace __MaterialUI { | |||
| targetOrigin?: propTypes.origin; | |||
| textFieldStyle?: React.CSSProperties; | |||
| } | |||
| export class AutoComplete extends React.Component<AutoCompleteProps, {}> { | |||
| export class AutoComplete extends React.Component<AutoCompleteProps<any>, {}> { | |||
There was a problem hiding this comment.
Yes it should, but TSX doesn't support generics yet.
Having a generic on the props allows you to hack around this and typecast with the generic.
const MyAutoComplete = AutoComplete as React.Commponent<AutoCompleteProps<MyDataItem>, {}>;
render(<MyAutoComplete />);
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.material-ui.com/#/components/auto-complete
Shows
errorTextandhintTextas nodes. Data source and data item definitions were only correct if thedataSourceConfigis not used to customize the functionality.masterbranch.Runnpm run lint -- package-nameif atslint.jsonis present.If changing an existing definition:
Increase the version number in the header if appropriate.