-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adal: Fix export style #19838
Merged
Merged
adal: Fix export style #19838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
pushed a commit
that referenced
this pull request
Oct 2, 2017
* Added tslint.json * Merge commit from source fork (#2) * Add setVisible to iFrame control * Initial API without namespaces. * Did more work on typings. * Final changes to the typings. * add className prop and make manager prop optional * [jquery.fancytree] added enableUpdate method (reference http://www.wwwendt.de/tech/fancytree/doc/jsdoc/Fancytree.html#enableUpdate) * Fix typo (any -> all) for everyWhere description * Minor Pixi.js updates to v4.5.5 * mfiles: Added missing CLSID constants * Reduce strictness of types for redux actions to reduce false positives * Set required tsc version for depended package * Update to index.d.ts Added change suggested by @pocesar * Updated test to reflect remote changes Second class, remoteBool to test for remote is boolean * mfiles: Added support for application platform property * bootstrap-datepicker - append all available datepicker events * Update Ignite UI typing definition according the latest 17.1 build * Added 'static' to Model.remoteMethod Integrated the remoteMethod ideas from https://github.com/Sequoia/loopback-type-definitions/blob/master/loopback.d.ts into the existing type Improves remoteMethod composition and checking. No impact on other types * add lost options member add comments * Updating comment in remoteMethod JSDoc Added simple test for remoteMethod * Fixing dtslint issues * Fixed errors from running tests. Travis CI should pass now * Updated test example with real parameters * update ColorWrap types * change type name * feat(prettier): update to version 1.7 * [angular-strap] updated all options to 2.3.8 * [angular-strap] added tslint and resolved linting issues * Remove moved file * Add separate process event contexts * export all interfaces from pdfjs-dist * Fix lint errors * Typo fix * Add editorState param to event handlers * Fix parse_response type and use lookup type * Change stage direction to proper case * [react-data-grid] Added openCellEditor signature to ReactDataGrid instance * Add remaining missing Xrm.Page.data.process methods * Add new label type for X/YAxis * Add contribution name * Update definitions for @types/angular-loading-bar to be accurate * Formatting update * Adding type for the function instead of just Function * Adding a test * Try to fix tests for angular-loading-bar types * feat(react-native-elements): pull from iRoachie * Update Label type * Support multiple colors / styles Winston supports configuring multiple styles rather than a single color. For example you could winston.addColors( { error: ['white', 'underline', 'bgRed'] }); * feat(react-native-element): add multiple components The work is not yet completed, however there are several components provided and the rest will be completed in the next few days. * fix(react-native-elements): unneeded breaking imports * Update d3-geo to version 1.7.1 Includes geoNaturalEarth1 and geoNaturalEarth1Raw * Type definitions for react-mce 0.6. * Use generic defaults. * Reduce TypeScript version to 2.3 * feat(react-native-elements): add rating component * feat(react-native-elements): add SearchBar component * webpack: improve loader context typings emitError() and emitWarning() both can accept an Error as well, for exposing caught Errors. See: https://github.com/webpack/webpack/blob/master/lib/NormalModule.js#L115 Added relevant type tests. * fix: do not make use of es6's Map and Set this should fix #16587 * feat(react-native-elements): add SideMenu component * feat(react-native-elements): add Slider component * feat(react-native-elements): add SocialIcons component * feat(react-native-elements): add SwipeDeck component * feat(react-native-elements): add Tabs component * feat(react-native-elements): add Tile component * feat(react-native-elements): add utility exports * docs(react-native-elements): remove deprecated message * first pass at the electron-winstaller declaration * lint * Adding definitions for prosemirror-table * Added minArea to DragBoxOptions (https://openlayers.org/en/latest/apidoc/ol.interaction.DragBox.html) * added minArea to test * Remove myself from list of maintainers * stripe-v3: Add basic typings for createSource method * stripe-v3: Lint SourceOptions * stripe-v3: Conert tabs to spaces * Add ChartFontOptions to global Chart.js options * angular-ui-router: Can't export a string literal (#19839) * angular-gridster: Can't export a string literal (#19842) * react-router/v2: Fix default export of object (#19849) * history/v2 and /v3: Fix export default of object (#19847) * Add definitions for W3C Web USB API * logat: Fix export (#19848) * adal: Fix export style (#19838) * strophe: Fix export (#19850) * express-brute-mongo: Fix export (#19851) * argparse: Remove unnecessary type parameters (#19843) * Support conditional values in Vega * Add onLoad animation configuration Alluded to here in documentation: https://formidable.com/open-source/victory/docs/victory-stack Code references: https://github.com/FormidableLabs/victory-core/blob/e28d4b81eaa0b303d88d7c3124aec4c77d8c9970/src/victory-util/default-transitions.js#L5 https://github.com/FormidableLabs/victory-core/blob/e28d4b81eaa0b303d88d7c3124aec4c77d8c9970/src/victory-util/default-transitions.js#L19 * Fix restify declarations to comply with standard lint rules. This change requires TypeScript 2.2 because the type 'object' did not exist in 2.1. * hopscotch small fixes, no breaking changes * fix typo fix typo * bull: added missing method "promote" from bull v3 to typings * Minor fixes from review * stripe-v3: Lint * types for tabulator * Ramda: disable no-unnecessary-generics (#19785) * fixing tests * adding more test * Merge PR #19726: [react-data-grid] Added getValidateFilterValues signature to GridProps * [react-data-grid] Added getValidateFilterValues signature to GridProps * Add resizerClassName * More verbose definition for pathOr * strictNullChecks: true
giabao
pushed a commit
to ohze/DefinitelyTyped
that referenced
this pull request
Oct 12, 2017
* Added tslint.json * Merge commit from source fork (DefinitelyTyped#2) * Add setVisible to iFrame control * Initial API without namespaces. * Did more work on typings. * Final changes to the typings. * add className prop and make manager prop optional * [jquery.fancytree] added enableUpdate method (reference http://www.wwwendt.de/tech/fancytree/doc/jsdoc/Fancytree.html#enableUpdate) * Fix typo (any -> all) for everyWhere description * Minor Pixi.js updates to v4.5.5 * mfiles: Added missing CLSID constants * Reduce strictness of types for redux actions to reduce false positives * Set required tsc version for depended package * Update to index.d.ts Added change suggested by @pocesar * Updated test to reflect remote changes Second class, remoteBool to test for remote is boolean * mfiles: Added support for application platform property * bootstrap-datepicker - append all available datepicker events * Update Ignite UI typing definition according the latest 17.1 build * Added 'static' to Model.remoteMethod Integrated the remoteMethod ideas from https://github.com/Sequoia/loopback-type-definitions/blob/master/loopback.d.ts into the existing type Improves remoteMethod composition and checking. No impact on other types * add lost options member add comments * Updating comment in remoteMethod JSDoc Added simple test for remoteMethod * Fixing dtslint issues * Fixed errors from running tests. Travis CI should pass now * Updated test example with real parameters * update ColorWrap types * change type name * feat(prettier): update to version 1.7 * [angular-strap] updated all options to 2.3.8 * [angular-strap] added tslint and resolved linting issues * Remove moved file * Add separate process event contexts * export all interfaces from pdfjs-dist * Fix lint errors * Typo fix * Add editorState param to event handlers * Fix parse_response type and use lookup type * Change stage direction to proper case * [react-data-grid] Added openCellEditor signature to ReactDataGrid instance * Add remaining missing Xrm.Page.data.process methods * Add new label type for X/YAxis * Add contribution name * Update definitions for @types/angular-loading-bar to be accurate * Formatting update * Adding type for the function instead of just Function * Adding a test * Try to fix tests for angular-loading-bar types * feat(react-native-elements): pull from iRoachie * Update Label type * Support multiple colors / styles Winston supports configuring multiple styles rather than a single color. For example you could winston.addColors( { error: ['white', 'underline', 'bgRed'] }); * feat(react-native-element): add multiple components The work is not yet completed, however there are several components provided and the rest will be completed in the next few days. * fix(react-native-elements): unneeded breaking imports * Update d3-geo to version 1.7.1 Includes geoNaturalEarth1 and geoNaturalEarth1Raw * Type definitions for react-mce 0.6. * Use generic defaults. * Reduce TypeScript version to 2.3 * feat(react-native-elements): add rating component * feat(react-native-elements): add SearchBar component * webpack: improve loader context typings emitError() and emitWarning() both can accept an Error as well, for exposing caught Errors. See: https://github.com/webpack/webpack/blob/master/lib/NormalModule.js#L115 Added relevant type tests. * fix: do not make use of es6's Map and Set this should fix DefinitelyTyped#16587 * feat(react-native-elements): add SideMenu component * feat(react-native-elements): add Slider component * feat(react-native-elements): add SocialIcons component * feat(react-native-elements): add SwipeDeck component * feat(react-native-elements): add Tabs component * feat(react-native-elements): add Tile component * feat(react-native-elements): add utility exports * docs(react-native-elements): remove deprecated message * first pass at the electron-winstaller declaration * lint * Adding definitions for prosemirror-table * Added minArea to DragBoxOptions (https://openlayers.org/en/latest/apidoc/ol.interaction.DragBox.html) * added minArea to test * Remove myself from list of maintainers * stripe-v3: Add basic typings for createSource method * stripe-v3: Lint SourceOptions * stripe-v3: Conert tabs to spaces * Add ChartFontOptions to global Chart.js options * angular-ui-router: Can't export a string literal (DefinitelyTyped#19839) * angular-gridster: Can't export a string literal (DefinitelyTyped#19842) * react-router/v2: Fix default export of object (DefinitelyTyped#19849) * history/v2 and /v3: Fix export default of object (DefinitelyTyped#19847) * Add definitions for W3C Web USB API * logat: Fix export (DefinitelyTyped#19848) * adal: Fix export style (DefinitelyTyped#19838) * strophe: Fix export (DefinitelyTyped#19850) * express-brute-mongo: Fix export (DefinitelyTyped#19851) * argparse: Remove unnecessary type parameters (DefinitelyTyped#19843) * Support conditional values in Vega * Add onLoad animation configuration Alluded to here in documentation: https://formidable.com/open-source/victory/docs/victory-stack Code references: https://github.com/FormidableLabs/victory-core/blob/e28d4b81eaa0b303d88d7c3124aec4c77d8c9970/src/victory-util/default-transitions.js#L5 https://github.com/FormidableLabs/victory-core/blob/e28d4b81eaa0b303d88d7c3124aec4c77d8c9970/src/victory-util/default-transitions.js#L19 * Fix restify declarations to comply with standard lint rules. This change requires TypeScript 2.2 because the type 'object' did not exist in 2.1. * hopscotch small fixes, no breaking changes * fix typo fix typo * bull: added missing method "promote" from bull v3 to typings * Minor fixes from review * stripe-v3: Lint * types for tabulator * Ramda: disable no-unnecessary-generics (DefinitelyTyped#19785) * fixing tests * adding more test * Merge PR DefinitelyTyped#19726: [react-data-grid] Added getValidateFilterValues signature to GridProps * [react-data-grid] Added getValidateFilterValues signature to GridProps * Add resizerClassName * More verbose definition for pathOr * strictNullChecks: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple things are exported we can just use
export const
instead ofexport =
.This is a new error due to microsoft/TypeScript#18444.