Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting peer deps in wordpress__block-editor #64850

Closed
wants to merge 1 commit into from

Conversation

sandersn
Copy link
Contributor

Added in #64680, not sure how it passed CI since it should be the same runner as the overnight run. Could be a different npm version.

Added in #64680, not sure how it passed CI since it should be the same
runner as the overnight run. Could be a different npm version.
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 22, 2023

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64850,
  "author": "sandersn",
  "headCommitOid": "b3f5a292281447df029f916da46552236b218340",
  "mergeBaseOid": "1d9d491c90bd1c852dea2a9ff36a7cf0bf48cd7c",
  "lastPushDate": "2023-03-22T15:49:50.000Z",
  "lastActivityDate": "2023-03-22T16:08:31.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wordpress__block-editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__block-editor/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1479824410,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @dsifford @sirreal @dmsnell — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

wordpress__block-editor (unpkg)

was missing the following properties:

  1. privateApis

Generated by 🚫 dangerJS against b3f5a29

@dmsnell
Copy link
Contributor

dmsnell commented Mar 22, 2023

@sandersn can you help me understand what broke with this, why it failed? and why this fixes? (honest question; I don't understand it)

@jakebailey
Copy link
Member

Basically it's this: WordPress/gutenberg#48009

But, I think we should just pass --legacy-peer-deps to work around this globally.

@sandersn
Copy link
Contributor Author

I agree, I'll go change dtslint-runner instead.

@sandersn sandersn closed this Mar 22, 2023
@jakebailey jakebailey deleted the word__block-editor-non-conflict-deps branch March 27, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants