Fix SSAO on OpenGL platforms [closes #21]

Delt06 · Mar 12, 2023 · f3664dc · f3664dc
1 parent 1379da3
commit f3664dc
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 4 deletions.
diff --git a/Assets/ToonRP/Runtime/GraphicsApiUtils.cs b/Assets/ToonRP/Runtime/GraphicsApiUtils.cs
@@ -0,0 +1,26 @@
+using UnityEngine;
+using UnityEngine.Rendering;
+
+namespace ToonRP.Runtime
+{
+    public static class GraphicsApiUtils
+    {
+        // OpenGL uses the [-1, 1] depth clip space.
+        // Other APIs use the [0, 1] range. 
+        public static bool OpenGlStyleClipDepth
+        {
+            get
+            {
+#if UNITY_WEBGL
+                return true;
+#else // !UNITY_WEBGL
+                GraphicsDeviceType api = SystemInfo.graphicsDeviceType;
+                return api is
+                    GraphicsDeviceType.OpenGLCore or
+                    GraphicsDeviceType.OpenGLES2 or
+                    GraphicsDeviceType.OpenGLES3;
+#endif // UNITY_WEBGL
+            }
+        }
+    }
+}
diff --git a/Assets/ToonRP/Runtime/GraphicsApiUtils.cs.meta b/Assets/ToonRP/Runtime/GraphicsApiUtils.cs.meta
diff --git a/Assets/ToonRP/Runtime/PostProcessing/ToonSsao.cs b/Assets/ToonRP/Runtime/PostProcessing/ToonSsao.cs
@@ -178,7 +178,8 @@ private void RenderMainPass()
             _cmd.SetRenderTarget(RtId, RenderBufferLoadAction.DontCare, RenderBufferStoreAction.Store);
 
             _cmd.SetGlobalTexture("_NoiseTexture", _noiseTexture);
-            _cmd.SetGlobalFloat("_Radius", _settings.Radius);
+
+            _cmd.SetGlobalFloat("_Radius", GetRadius());
             _cmd.SetGlobalFloat("_Power", _settings.Power);
             _cmd.SetGlobalVector("_NoiseScale",
                 new Vector4((float) _width / _noiseTexture.width, (float) _height / _noiseTexture.height)
@@ -188,6 +189,17 @@ private void RenderMainPass()
             Draw(MainPass);
         }
 
+        private float GetRadius()
+        {
+            float radius = _settings.Radius;
+            if (GraphicsApiUtils.OpenGlStyleClipDepth)
+            {
+                radius *= 2;
+            }
+
+            return radius;
+        }
+
         private void RenderBlur(Vector2 direction, in RenderTargetIdentifier source)
         {
             _cmd.SetGlobalVector("_Direction", direction);

diff --git a/Assets/ToonRP/Shaders/PostProcessing/ToonRPSSAO.shader b/Assets/ToonRP/Shaders/PostProcessing/ToonRPSSAO.shader
@@ -7,6 +7,7 @@
 	{
 	    ZTest Off
 		ZWrite Off
+	    Cull Off
 
 	    HLSLINCLUDE
 
@@ -54,14 +55,14 @@
 
             #include "../../ShaderLibrary/DepthNormals.hlsl"
 
-			#define SAMPLES_COUNT 64
+			#define MAX_SAMPLES_COUNT 64
 			#define NORMAL_BIAS 0.0
             #define DEPTH_BIAS 0.01
 
 			CBUFFER_START(ToonRpSsao)
 			float2 _NoiseScale;
 			int _KernelSize;
-			float4 _Samples[SAMPLES_COUNT];
+			float4 _Samples[MAX_SAMPLES_COUNT];
 			float _Radius;
 			float _Power;
 			CBUFFER_END
@@ -83,7 +84,8 @@
 			float4 RestorePositionVs(float3 positionNdc, const float4x4 inverseProjection)
             {
                 float4 positionVs = mul(inverseProjection, float4(positionNdc, 1.0));
-                positionVs /= positionVs.w;
+                positionVs.xyz /= positionVs.w;
+			    positionVs.w = 1;
                 return positionVs;
             }