Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSM precision issues (with both Half and Float) #158

Closed
Delt06 opened this issue Nov 13, 2023 · 2 comments
Closed

VSM precision issues (with both Half and Float) #158

Delt06 opened this issue Nov 13, 2023 · 2 comments
Labels
Bug Something isn't working Lighting/Shadows Lighting, shadows, GI, etc.
Milestone
v0.8.0

Comments

@Delt06
Copy link
Owner

Delt06 commented Nov 13, 2023

image
@Delt06 Delt06 added Bug Something isn't working Lighting/Shadows Lighting, shadows, GI, etc. labels Nov 13, 2023
@Delt06 Delt06 added this to the v0.8.0 milestone Nov 13, 2023
@Delt06 Delt06 changed the title VSM Regression: precision issues VSM Regression: precision issues (with both Half and Float) Nov 13, 2023
@Delt06
Copy link
Owner Author

Delt06 commented Nov 13, 2023

Might be after a format change.

@Delt06 Delt06 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
@Delt06 Delt06 reopened this Nov 28, 2023
@Delt06 Delt06 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
@Delt06 Delt06 reopened this Dec 8, 2023
@Delt06 Delt06 changed the title VSM Regression: precision issues (with both Half and Float) VSM precision issues (with both Half and Float) Dec 8, 2023
@Delt06
Copy link
Owner Author

Delt06 commented Dec 8, 2023 •
edited
Loading

It is even present in v0.1.0, might be something external.

Delt06 added a commit that referenced this issue Dec 19, 2023
@Delt06
Add precision compensation to VSM shadows [#158]
aa5addb
@Delt06 Delt06 closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Lighting/Shadows Lighting, shadows, GI, etc.
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
1 participant
@Delt06