Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XR Support + Bloom Improvements #212

Merged
merged 52 commits into from
Jan 27, 2024
Merged

XR Support + Bloom Improvements #212

merged 52 commits into from
Jan 27, 2024

Conversation

Delt06
Copy link
Owner

@Delt06 Delt06 commented Jan 21, 2024 •
edited
Loading

Closes #213, Closes #214

  • Single Pass Instanced
  • Mirror View
  • Occlusion Mesh
  • Copy Depth
  • Ensure feature support
    • Pre-Pass
      • Depth
      • Normals
    • Sampling Depth/Color during forward pass
      • Depth texture
      • Opaque texture
    • Skybox
    • Rendering to an intermediate RT
    • Post Processing
      • Post FX Stack
      • Bloom
      • Debug
        • Pre-pass
      • Screen-Space Outlines
        • Post-Processing
        • After Opaque
      • Sharpen
      • Light Scattering
      • SSAO
        • Only in XR: When NOT rendering to an intermediate texture
    • Off-Screen Transparency
      • When NOT rendering to an intermediate texture
      • Fix in scene view
    • MSAA
  • Ensure GAPI support
    • DX11
    • Vulkan
    • OpenGLES
    • WebGL: fix MSAA
  • Selectively disable XR (toggle on additional camera data, when rendering to an RT)
  • Wiki page

Will do later (create issues):

  • XR: Foveated rendering
  • XR: native render pass

Most likely won't support (add errors):

  • Multi/partial camera viewport
  • Temporal AA
  • Motion Vectors Pre-Pass
  • Tiled Lighting
  • Multi Pass stereo rendering

Delt06 added 27 commits January 21, 2024 00:04
@Delt06
Basic XR setup
4aa1503
@Delt06
XR: fix stereo for graph shaders, ensure we output stereo for default…
eb147a5 
… shaders
@Delt06
XR: implement rendering to an XR target with proper viewport
42d4ef9
@Delt06
XR: add stereo macros to the default inverted hull outline shader
db769ec
@Delt06
XR: add mirror view shader
f023eea
@Delt06
XR: add skybox support
5ac28b2
@Delt06
XR: implement occlusion mesh
f6b75a5
@Delt06
XR: add UNITY_VERTEX_INPUT_INSTANCE_ID to the built-in outline shader
057e525
@Delt06
Implement proper final blit as a shader
b323fea
@Delt06
XR: fix rendering to an temporary RT array not using all slices
325adb6
@Delt06
XR: add post-processing stack support
6e9e13f
@Delt06
XR: add multipass usage error
1ad4625
@Delt06
XR: extract common texture array fixup logic
6e36f01
@Delt06
XR: make bloom XR-compatible
8d7854d
@Delt06
XR: make MSAA XR-compatible
ea24c98
@Delt06
XR: remove the multi-pass error because of false positives
1b2020b
@Delt06
RT Handles: realloc on MSAA change
0343acc
@Delt06
Remove commented requireMsaaRenderToTexture
888db83
@Delt06
OpenGL: add cull off for Bloom
05d75a7
@Delt06
XR: implement copy depth
5107e0a
@Delt06
Bloom: control pattern's luminance threshold to avoid small details
d742958
@Delt06
Bloom: add pattern dot size limit
981d2f3
@Delt06
Cyberpunk demo: return old bloom scale
5c18bf4
@Delt06
Bloom: allow for smoother patterns: blend pattern and classic bloom v…
039d917 
…alue
@Delt06
Bloom: remove bicubic sampling
fbeb4f2
@Delt06
XR: remove unused commented method
7ea5dc2
@Delt06
XR: add pre-pass support
58c3f0e
@Delt06 Delt06 changed the title XR Support XR Support + Bloom Improvements Jan 22, 2024
Delt06 added 23 commits January 24, 2024 17:41
@Delt06
XR: add opaque texture support
e49d10d
@Delt06
XR: add support for screen-space outlines
b773247
@Delt06
XR: add sharpen support
ee4fdb9
@Delt06
XR: add light scattering support
ea037f6
@Delt06
XR: add SSAO support
0406ce4
@Delt06
XR: add stereo support for the built-in inverted hull outlines shader
6dfd522
@Delt06
XR: add off-screen transparency support
ecbb269
@Delt06
XR: add a workaround for flipped SSAO
ce047a9
@Delt06
XR: optimize off-screen transparency and fix the case when rendering …
c37fa49 
…directly to XR texture
@Delt06
XR: fix projection matrix inconsistencies with SSAO and Off-Screen Tr…
46cc9a5 
…ansparency
@Delt06
Merge branch 'master' into xr
372dd95
@Delt06
XR: add a toggle on additional camera data to disable XR per-camera
c1d1468
@Delt06
XR: add missing UNITY_SETUP_STEREO_EYE_INDEX_POST_VERTEX to shader gr…
a455198 
…aph includes
@Delt06
XR, OpenGLES: add a workaround to a compiler bug, causing eye index t…
08c23fa 
…o store garbage data for some shaders
@Delt06
Enable new input system
4ca70ea
@Delt06
XR: fix XRMirrorView.shader causing compilation errors for non XR pla…
4431fe9 
…tforms
@Delt06
XR: fix the MSAA for WebGL bug, caused by the new XR render target im…
a41fd72 
…plementation
@Delt06
XR: add proper fixup for native render pass camera depth checks
fbb1527
@Delt06
XR: add MSAA native render pass support, yet disable render pass for …
6b0bee4 
…XR, it will be moved to a separate issue
@Delt06
XR: fix a compile error when accessing copy depth and XR is not prese…
21a157e 
…nt in the project
@Delt06
XR: add full qualified name in stripping
4f77801
@Delt06
XR: add errors on Temporal AA and Tiled Lighting
47ce98a
@Delt06
XR: add XR platform to README
bb0e34c
@Delt06 Delt06 marked this pull request as ready for review January 27, 2024 11:58
@Delt06 Delt06 merged commit a458778 into master Jan 27, 2024
@Delt06 Delt06 deleted the xr branch January 27, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bloom Pattern Improvements XR Support
1 participant
@Delt06