Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locker health rework #3084

Merged
merged 11 commits into from
Mar 4, 2025
Merged

Locker health rework #3084

merged 11 commits into from
Mar 4, 2025

Conversation

KZhProgram
Copy link
Contributor

About the PR

Made it so that command lockers have 75 health, regular secure lockers only have 50 health, and gun safe lockers have 125.

Why / Balance

I noticed there was a discrepancy in the health between command lockers and that the psionic mantis cabinet unusually had (on paper) 250 health. Furthermore, it didn't quite make sense that the gun safe (something that costs 10 plasteel) to have the same health as something that only used steel. After discussing on Discord I came to the numbers I have now.

This will affect people who are attempting to smash into lockers (therefore mostly thieves or syndies with steal objectives). Though, since the emag does exist, I doubt it'd be a huge gamechanger.

Technical details

I created a new entity called CommandLockerBaseSecureDeltaV as a way to easily distinguish between regular secure lockers and command lockers. This was so that I didn't need to copy and paste health changes for every command locker which made the code a bit more versatile I think (granted I doubt this will come into play anytime soon since we likely aren't adding any more command roles/lockers but who knows).

I also moved LockerForensicMantis out of Nyano and into _DV as well as removed a few things that were giving it a damage resistance.

Finally, the gun safes had their Destructible threshold raised so that the 10 plasteel in its construction was justified.

Media

N/A

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Locker health rework! Gun safes now have 125 health, department head lockers have 75, and every other secure locker now has 50 with psionic mantis cabinet health suffering the biggest nerf. No more 250 health mantis cabinets

@KZhProgram KZhProgram requested a review from a team as a code owner March 1, 2025 22:51
@github-actions github-actions bot added Changes: YML Changes any yml files size/M 64-255 lines S: Needs Review labels Mar 1, 2025
@ewokswagger
Copy link
Contributor

Bringing in for direction review. Will come back with a response in about 24h.

# Conflicts:
#	Resources/Prototypes/Nyanotrasen/Entities/Structures/Storage/Closets/Lockers/lockers.yml
#	Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
@KZhProgram KZhProgram requested a review from deltanedas March 2, 2025 00:45
@deltanedas deltanedas requested a review from a team March 2, 2025 01:41
@KZhProgram
Copy link
Contributor Author

🥺

@ewokswagger
Copy link
Contributor

Direction Approved!

@deltanedas deltanedas merged commit 3d26efc into DeltaV-Station:master Mar 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants