-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locker health rework #3084
Merged
Merged
Locker health rework #3084
+59
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lockers have 50 health
Bringing in for direction review. Will come back with a response in about 24h. |
deltanedas
requested changes
Mar 1, 2025
Resources/Prototypes/Nyanotrasen/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
…lockers have 50 health
# Conflicts: # Resources/Prototypes/Nyanotrasen/Entities/Structures/Storage/Closets/Lockers/lockers.yml # Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
deltanedas
approved these changes
Mar 2, 2025
🥺 |
Direction Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Made it so that command lockers have 75 health, regular secure lockers only have 50 health, and gun safe lockers have 125.
Why / Balance
I noticed there was a discrepancy in the health between command lockers and that the psionic mantis cabinet unusually had (on paper) 250 health. Furthermore, it didn't quite make sense that the gun safe (something that costs 10 plasteel) to have the same health as something that only used steel. After discussing on Discord I came to the numbers I have now.
This will affect people who are attempting to smash into lockers (therefore mostly thieves or syndies with steal objectives). Though, since the emag does exist, I doubt it'd be a huge gamechanger.
Technical details
I created a new entity called CommandLockerBaseSecureDeltaV as a way to easily distinguish between regular secure lockers and command lockers. This was so that I didn't need to copy and paste health changes for every command locker which made the code a bit more versatile I think (granted I doubt this will come into play anytime soon since we likely aren't adding any more command roles/lockers but who knows).
I also moved LockerForensicMantis out of Nyano and into _DV as well as removed a few things that were giving it a damage resistance.
Finally, the gun safes had their Destructible threshold raised so that the 10 plasteel in its construction was justified.
Media
N/A
Requirements
Breaking changes
Changelog
🆑