Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thaven patch 1 - mood sync, moodupset glimmer 500, speech bubble #3088

Merged
merged 9 commits into from
Mar 3, 2025

Conversation

kushbreth
Copy link
Contributor

About the PR

-edited the threshold for moodupsets from 700 glimmer to 500
-added 5 new body markings
-added a custom speech bubble

Why / Balance

-moodupsets basically never happen ever forever
-why not add more markings?

Technical details

mostly yml and json edits, added new sprites for markings and the speech bubble, changed the gamerule event for moodupsets

Media

image 1
original character DO NOT STEALS

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

none

Changelog

🆑 sowelipililimute, kushbreth

  • add: thaven moodupsets possible at 500 glimmer, new thaven markings, new thaven speech bubble

@kushbreth kushbreth requested review from a team as code owners March 2, 2025 01:41
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi size/M 64-255 lines labels Mar 2, 2025
Copy link
Contributor

github-actions bot commented Mar 2, 2025

RSI Diff Bot; head commit 4935ed1 merging into f230ecd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/ears.rsi

State Old New Status
long_ears_small Modified

Resources/Textures/_DV/Effects/speech.rsi

State Old New Status
thaven0 Added
thaven1 Added
thaven2 Added

Resources/Textures/_DV/Mobs/Customization/thaven.rsi

State Old New Status
carp_spots Added
cheek_barbels Added
eyebrow_barbels Added
underbelly_face Added
underbelly_torso Added

Edit: diff updated after 4935ed1

@github-actions github-actions bot added size/L 256-1023 lines and removed size/M 64-255 lines labels Mar 2, 2025
@Lyndomen
Copy link
Contributor

Lyndomen commented Mar 2, 2025

🅱️ direction review gaming 23 hours 12 minutes 40 seconds

@github-actions github-actions bot added size/M 64-255 lines and removed size/L 256-1023 lines labels Mar 2, 2025
Lyndomen
Lyndomen previously approved these changes Mar 3, 2025
@deltanedas deltanedas merged commit b91485c into DeltaV-Station:master Mar 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants