-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fake rock anom #3092
Added fake rock anom #3092
Conversation
Added a cosmetic rock anomaly infection
layers: | ||
- state: icon | ||
shader: unshaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove layers on Clothing it does nothing
shader: unshaded | ||
- type: Tag | ||
tags: | ||
- WhitelistChameleon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add trailing newline
- type: entity | ||
parent: ClothingNeckBase | ||
id: ClothingNeckAnomalyrock | ||
name: Fake Anomaly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase
parent: ClothingNeckBase | ||
id: ClothingNeckAnomalyrock | ||
name: Fake Anomaly | ||
description: A near 1:1 re-creation of an anomalous infection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a .
at the end
{ | ||
"version": 1, | ||
"license": "CC-BY-SA-3.0", | ||
"copyright": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright isnt optional
{ | ||
"name": "icon" | ||
}, | ||
{ | ||
"name": "equipped-NECK", | ||
"directions": 4, | ||
"delays": [ | ||
[ | ||
0.8, | ||
0.8, | ||
0.8, | ||
0.8 | ||
], | ||
[ | ||
0.8, | ||
0.8, | ||
0.8, | ||
0.8 | ||
], | ||
[ | ||
0.8, | ||
0.8, | ||
0.8, | ||
0.8 | ||
], | ||
[ | ||
0.1, | ||
0.1, | ||
0.1, | ||
0.1 | ||
] | ||
] | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 space indent dont mix it with 2
the rsi validator is failing on the 0.1s at the end, change them to 0.8 like the rest
also missing trailing newline
Direction is reviewing, get back to you in about a day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Direction here,
We've discussed and concluded that we'd prefer to leave these extra-impactful visual effects for the special events that cause them (like having an anomalous infection). Both to keep those feeling special and to not confuse epi.
If you'd like to PR something like a "infection inspired" cosmetic that clearly looks cosmetic and different, we'd be willing to review that separately. For this particular PR we are requesting it closed, though.
Added a cosmetic rock anomaly infection
About the PR
Added a new fake rock anomaly infection purely cosmetic clotheing that takes the neck slot
Why / Balance
Because i had the idea of cosmetic anomlies for some really cool fits! and to trick epistemics as the clown/mime.
Technical details
Media
Requirements
Breaking changes
Changelog
Added a cosmetic anomaly for people to make new drip with! (currently no way to get it without admin)
🆑
Added fake rock anomaly as a cosmetic(can only be obtained via admin spawn as of now)
-->