Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fake rock anom #3092

Closed

Conversation

furrylover833
Copy link

Added a cosmetic rock anomaly infection

About the PR

Added a new fake rock anomaly infection purely cosmetic clotheing that takes the neck slot

Why / Balance

Because i had the idea of cosmetic anomlies for some really cool fits! and to trick epistemics as the clown/mime.

Technical details

Media

image
image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
Added a cosmetic anomaly for people to make new drip with! (currently no way to get it without admin)
🆑
Added fake rock anomaly as a cosmetic(can only be obtained via admin spawn as of now)

-->

Added a cosmetic rock anomaly infection
@furrylover833 furrylover833 requested review from a team as code owners March 2, 2025 16:42
@github-actions github-actions bot added size/M 64-255 lines S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed S: Needs Review labels Mar 2, 2025
Copy link
Contributor

github-actions bot commented Mar 2, 2025

RSI Diff Bot; head commit 553971e merging into 69b8ce4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/Neck/Misc/cosmeticanomalies.rsi

State Old New Status
equipped-NECK Added
icon Added

Edit: diff updated after 553971e

Comment on lines +58 to +60
layers:
- state: icon
shader: unshaded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove layers on Clothing it does nothing

shader: unshaded
- type: Tag
tags:
- WhitelistChameleon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add trailing newline

- type: entity
parent: ClothingNeckBase
id: ClothingNeckAnomalyrock
name: Fake Anomaly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase

parent: ClothingNeckBase
id: ClothingNeckAnomalyrock
name: Fake Anomaly
description: A near 1:1 re-creation of an anomalous infection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a . at the end

{
"version": 1,
"license": "CC-BY-SA-3.0",
"copyright": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright isnt optional

Comment on lines +10 to +44
{
"name": "icon"
},
{
"name": "equipped-NECK",
"directions": 4,
"delays": [
[
0.8,
0.8,
0.8,
0.8
],
[
0.8,
0.8,
0.8,
0.8
],
[
0.8,
0.8,
0.8,
0.8
],
[
0.1,
0.1,
0.1,
0.1
]
]
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space indent dont mix it with 2
the rsi validator is failing on the 0.1s at the end, change them to 0.8 like the rest

also missing trailing newline

@ThataKat
Copy link
Contributor

ThataKat commented Mar 2, 2025

Direction is reviewing, get back to you in about a day!

Copy link
Contributor

@ThataKat ThataKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction here,

We've discussed and concluded that we'd prefer to leave these extra-impactful visual effects for the special events that cause them (like having an anomalous infection). Both to keep those feeling special and to not confuse epi.

If you'd like to PR something like a "infection inspired" cosmetic that clearly looks cosmetic and different, we'd be willing to review that separately. For this particular PR we are requesting it closed, though.

@deltanedas deltanedas closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants