port better borgs from frontier #3110
Merged
+507
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#2766) * WIP: droppable, swappable, insertable cyborg items * Half-baked borg HandPlaceholderComponent * cyborg: sprite representation for empty slots * nullable prototype --------- Co-authored-by: Dvir <[email protected]>
* BorgSystem: check droppable items for duped mods * Cache item comparer
github-actions
bot
added
S: Needs Review
size/L
deltanedas
force-pushed
the
borg-hand-ops
branch
from
bfdf50e to
0b34e54
Compare
Toby222
reviewed
Mar 4, 2025
| @@ -14,15 +15,27 @@ public sealed partial class ItemBorgModuleComponent : Component | |||
| /// <summary> | |||
| /// The items that are provided. | |||
| /// </summary> | |||
| [DataField("items", customTypeSerializer: typeof(PrototypeIdListSerializer<EntityPrototype>), required: true)] | |||
| [DataField("items", customTypeSerializer: typeof(PrototypeIdListSerializer<EntityPrototype>))] // Frontier: removed | |||
There was a problem hiding this comment.
this should probably be removed "required: true"?
There was a problem hiding this comment.
it exists on frontier, dont want a deltav comment for correcting a frontier comment 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
borg hands finally real
some modules can drop items which can then be picked back up if an item matches its whitelist
currently its just bucket beaker plant/ore/book bags will add more stuff later for engi and sec mostly
Why / Balance
good and needed for secborgs arresting people
Technical details
ported from frontier, same prs goob is stealing from
added code to apply metal fibers to items that get picked up
nothing is predicted so its annoying but can fix it later to reuse the placeholder entity so client can predict stuff
Media
bucket ops
Requirements
Breaking changes
no
Changelog
🆑 whatston3