update wflow build notebook #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalmijn
approved these changes
Mar 25, 2024
examples/build_model.ipynb
Outdated
Comment on lines
146
to
148
| "source": [ | ||
| "Once we have prepared our data catalog and model build settings file, we are ready to ask HydroMT to build our Wflow model. This can be done from the command line and here is an example for the Northern part of the Piave basin in Italy:" | ||
| ] |
There was a problem hiding this comment.
Small comment:
I'd split the second sentence into two parts, e.g:
Building the model can be done from the command line. Down below is an example for the Northern part of the Piave basin in Italy:
You can disregard it if you disagree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #256
Explanation
We removed default merit_hydro value in setup_basemaps so the example of building a model without suppliying a config file does not work anymore.
The behavior is anyway not common and will be deprecated in hydromt v1 so I now removed that part of the example.
Checklist
main