-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix subbasin #263
Bugfix subbasin #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and code is good, but do check the comments on the description of the errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Code works, still some changes are needed related to the error messaging
Also checked on local machine for following scenarios:
- build regular model, looks good
- too coarse resolution -> error as expected
- too high upa -> error as expected
- weird location for subbasin outlet -> error as expected
- missing streamflow info so too small model -> error as expected
- small model -> warning as expected
Issue addressed
Fixes #236
Fixes #261
Explanation
Earlier error messages.
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.