-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for alpha_h1
parameter and the GLCNMO
dataset
#272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @JoostBuitink !
Just very small comments before this is ready, I'll let you look into it.
Also nice that you added now the updating of the names in the toml file!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good now @JoostBuitink ! Just one small final comment but for the rest it's okay to merge!
Co-authored-by: hboisgon <[email protected]>
Issue addressed
No issue, but fixes the last bullet in #226 (comment)
Also adds support for the GLCNMO land use dataset. This dataset is used for (global) models to identify regions where rice/paddy fields are located. Adding support for this dataset ensures more consistent model building.
Explanation
LULC parameters are based on existing tables. Alpha_h1 values are set to zero for all crops (not-natural vegetation), and set to 1 for all natural vegetation, based on the idea that natural vegetation is adapted to the local conditions and can deal with saturated conditions, while crops are likely not able to handle those conditions.
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.