-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add setup_lulcmaps_from_vector #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Hélène! Nice feature, I will test it myself this week to make some nice LULC maps, which I luckily still have to do for a project. These are my comments based on reviewing only the code and not running it yet
Thanks for the useful review and comments @shartgring ! I think I adressed it all :) could you review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only 1 thing is missing: I noticed that the LULC map (wflow_landuse) is not clipped to the basin, but to the bounding box. The parameter maps themselves are clipped correctly to the basin. So that is a small thing that is nice to address
Still I'll approve it and nice that it can be included in the release!
Issue addressed
No issue was created.
Explanation
Often local landuse data is in vector/shapefile format rather than vector. This function allows to use vector by first rasterizing to a high resolution grid (resolution from user) before calling the classic
setup_lulcmaps
function.An equivalent
setup_lulcmaps_from_vector_with_paddy
was not added as users will be able to save the rasterized version of the landuse in theroot/maps
folder, so they can first callsetup_lulcmaps_from vector
and thensetup_lulcmaps_with_paddy
using the previously saved rasterized version of the landuse.Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.