Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post admin interface improvements #641

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Jan 4, 2023

Closes #536
Ref pyca/cryptography#7959

  • Adds blog filter by author and published status
  • Makes blogs searchable by blog title
  • Adds category and date to the blog list display

This work does NOT:

  • resolve url tag query which works in dev but not in production.
  • offer filter by tags in admin as lists were not an acceptable argument type

Screenshot 2023-01-05 at 2 35 07 AM

@VirginiaDooley VirginiaDooley changed the title Improve tag filter test on Post Blog post admin interface improvements Jan 4, 2023
@VirginiaDooley VirginiaDooley force-pushed the feature/blog-admin-improvements branch from a4f8725 to 7085627 Compare January 4, 2023 14:10
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 68.85% // Head: 69.04% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (f2ab8dd) compared to base (c7d3392).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f2ab8dd differs from pull request most recent head 6eec140. Consider uploading reports for the commit 6eec140 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   68.85%   69.04%   +0.18%     
==========================================
  Files          43       43              
  Lines         655      659       +4     
==========================================
+ Hits          451      455       +4     
  Misses        204      204              
Impacted Files Coverage Δ
democracy_club/apps/hermes/admin.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VirginiaDooley VirginiaDooley force-pushed the feature/blog-admin-improvements branch 2 times, most recently from 92d0a3e to 59af104 Compare January 4, 2023 23:40
@VirginiaDooley VirginiaDooley marked this pull request as ready for review January 4, 2023 23:40
@VirginiaDooley
Copy link
Contributor Author

@VirginiaDooley VirginiaDooley force-pushed the feature/blog-admin-improvements branch 2 times, most recently from 9ceccfb to f2ab8dd Compare January 5, 2023 17:43
Copy link
Contributor

@Bekabyx Bekabyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the conflict resolution, all looks good to me :)

@VirginiaDooley VirginiaDooley force-pushed the feature/blog-admin-improvements branch 2 times, most recently from e88c7ba to a3066b7 Compare January 9, 2023 13:13
@VirginiaDooley VirginiaDooley force-pushed the feature/blog-admin-improvements branch from a3066b7 to 25d444e Compare January 10, 2023 11:33
@VirginiaDooley VirginiaDooley force-pushed the feature/blog-admin-improvements branch from 25d444e to 6eec140 Compare January 10, 2023 11:37
@VirginiaDooley VirginiaDooley merged commit ad3ace8 into master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog post admin interface improvements
3 participants