Feature/devrefac 0 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* state_diagnose at realize failed in debug mode because of sum() of uninitialized variables * remove debug switches * remove extra 'HK' print statements
* model completes 6hrs in debug mode and writes out_pnt.points and out_grd.mx100
* some variables should be used from the shel inp routine for ufs but set locally for cesm * restarts, grd and point output being written for ufs but file name has no time string information
*in debug mode, using dedicated ('second') output stream
produces non-identical ww3 restarts, but the model itself reproduces
this mode produces timestamped restart files
* in debug mode, using no data server mode, the ww3 restarts are
reproducible. this mode produces restarts restartXXX.ww3. base case
produces restarts at 09,012 (check in log.ww3), filenames restart001,
restart002. rest case produces only h=012, filename restart001.
cmp rest/restart001.ww3 base/restart002.ww3 shows the ww3 restarts
are b4b
* move 'set time frame' block earlier to allow cesm access to time and dtime_sync to set odat * force odat(j=4) to be printed only once to log in wav_shel_inp * added "1" to end of point and grid out put spec in ww3_shel.inp input file to force pre-pending by time
* remove flds_scalar_name from ToWave list, simplifies logic for check_global SR * set import_mask at start of import_fields using global reduction and uwnd field from import state * adds check_global routine for dumping out fields read from file, the merged fields when merge_import is true and the import_mask
… into feature/w3capbs4
* in ww3_shel.F90, ndsf(3) is assigned unit number 13 so use that unit number in readfromfile
* set dbug_flag to > 10 to write check_global
* remove import_mask from argument list
* For point output, use open(newunit=ndsl....). Previously, ndsl was assigned to unit=50, which corrupts the PET logging function (pet logging would be switched to fort.50). * fix bad copy/paste error where cesm flag was missing type (logical)
* change variable names for user set items * add a couple more flags, remove ifdefs on formats
* add all defined flags to wav_shr_flags * make all flags available in wav_shel_inp.F90 * add print_memcheck utility * clean up white space w3meminfo.F90
* baseline 20220629
…into feature/playwithshel
* add msgunit = 740+iaproc for either memcheck or debugint * replace W3_MEMCHECK with call to print_memcheck
* use ringinterval set from configuration attributes to set dtout(1) for history and dtout(4 or 8) for restarts. this allows removal of user_restalarm and user_histalarm. gridded output and restarts can be written in w3wave using the native ww3 timer. * rename user_grdncout to user_netcdf_grdout * remove outfreq since it is not used * text alignment and other whitespace changes
* close unit ndsi when reading shel.inp file * write log message for naprst in w3iorsmd
* cesm needs rstwr control to prevent writing restart at initial time
* use timen,time0 to set odat in wav_shel_inp
This reverts commit 1bc5a86.
Sync develop into dev/ufs-weather-model
* revert alarm control which broke cesm restart and history writes * add initial flag control for debug and tracing options in w3wave and w3init primarily * move implicit none to module default * remove serial ifdefs which appear once flags control some options * indent and text align
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Description
Issue(s) addressed
Commit Message
Check list
Testing