Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): Added Rishabh2804 to examples #143

Merged
merged 1 commit into from
Oct 2, 2022
Merged

docs(readme): Added Rishabh2804 to examples #143

merged 1 commit into from
Oct 2, 2022

Conversation

Rishabh2804
Copy link
Contributor

Summary

Added another awesome username, who uses the fantastic typing-SVG feature😄!!

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

@Rishabh2804
Update README.md
8923530 
Added another awesome username, who uses the fantastic typing-SVG feauture😄!
DenverCoder1
DenverCoder1 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

If I may make a suggestion, it seems that the text gets cut off at the top, at least on my computer. You should be able to fix that by increasing the height parameter.

image

@Rishabh2804
Copy link
Contributor Author

Thanks for highlighting the issue!
I have increased the height parameter, hopefully, it should look fine now.

Thanks again bud!
😄

@DenverCoder1 DenverCoder1 changed the title Added Rishabh2804 to examples docs(readme): Added Rishabh2804 to examples Oct 2, 2022
@DenverCoder1 DenverCoder1 merged commit 7cc732e into DenverCoder1:main Oct 2, 2022
@DenverCoder1 DenverCoder1 added the documentation Improvements or additions to documentation label Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rishabh2804 @DenverCoder1