-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source distribution does not observe the file/path excludes and is too big #294
Comments
@ceteri i have pushed up a WIP of the poetry conversion. So there is a pyproject.toml set up for poetry, but have not got to the point to convert to build the package as yet. |
Many thanks @jake-aft I have a hunch that the Python docs somehow change substantially between 3.8 and latest online (3.11) so that the reserved words here are different: https://docs.python.org/3/distutils/commandref.html#sdist-cmd |
For whatever reason the "egg" part of a source distribution ignores the I've tried to use |
@ceteri maybe its silly, but could we chmod the dirs we want to exclude and make them not readable, and then build the package? Not a great thing, but maybe for a workaround if we need to get the build out? |
Instead of directory permissions, tt'd probably be good if the SPARQL tests could pull down benchmark data from another source, instead of having that all be included in the repo. That said, there must be ways to exclude paths and files from a source distribution. I've been testing, but there are changes in the Python build specs between 3.8 and 3.10-3.11, which is right where Something between the docs' diffs and my brain and the Py tools impl just doesn't quite work as advertised? :) |
@jake-aft if poetry doesn't resolve this, |
Found the issue, which is explained here: TL;DR: In our case, this results in 10:1 reduction of the source distribution. |
I'm submitting a
This subsumes #275
Currently when using either
pyproject.toml
orsetup.py
approaches to build source and wheel, the wheel for a release is ~400Kb while the source distribution is ~300Mb, which is too large for PyPi.Note that the former was moved to
wip/pyproject.toml
since its use withFlit
appeared to be bugging. PerhapsPoetry
works better?See the
MANIFEST.in
file, where there are bothinclude
andexclude
statements getting used. For some reason, these rules are followed when building a wheel, but not when building a source distribution (sdist
)@Mec-iS @tomaarsen @jake-aft - do you have any suggestions about the library packaging here could be structured better for avoid this issue?
The text was updated successfully, but these errors were encountered: