Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour
All the methods are stacked in the
kglab
module and it makes it difficult to handle.New expected behaviour
Implement mixins for different functionalities in different modules:
SPARQL queryingimplemented by this PR@ceteri let me know if this is ok. The only problem I see is that the credits for writing the code are moved to the developer that created the mixin. So if you want to keep the credits to the developer that wrote the code in the first place he/she will have to create the mixins by himself. Let me know if this is a problem.
Change logs
querying
module that incapsulates querying forKnowledgeGraph
querying
out ofKnowledgeGraph
intoQueryingMixin