Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serilization-deserialization mixin #263

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Add serilization-deserialization mixin #263

merged 2 commits into from
Sep 1, 2022

Conversation

Mec-iS
Copy link
Contributor

@Mec-iS Mec-iS commented Sep 1, 2022

Moved serialization and deserialization into a separate mixin

@Mec-iS Mec-iS requested review from ceteri and tomaarsen September 1, 2022 10:30
@tomaarsen tomaarsen mentioned this pull request Sep 1, 2022
Merged
ceteri
ceteri approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@ceteri ceteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Mec-iS !
BTW, no need to add me on "authored by" :)

@ceteri ceteri merged commit 315f611 into DerwenAI:main Sep 1, 2022
@Mec-iS Mec-iS mentioned this pull request Sep 1, 2022
Closed
@Mec-iS Mec-iS deleted the refactor-with-mixins branch September 1, 2022 17:44
@Mec-iS
Copy link
Contributor Author

Mec-iS commented Sep 1, 2022

I will feel bad if I don't provide attribution... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceteri ceteri ceteri approved these changes

@tomaarsen tomaarsen Awaiting requested review from tomaarsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mec-iS @ceteri