More aggressive static declarations #347
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as #346, we can revisit that when the internal editor is built for Windows. It uses a lot of functions from the game. Thanks for the effort anyways, I hope we can merge it sometime! |
|
I approve the changes too |
MaddTheSane
force-pushed
the
staticFuncs
branch
3 times, most recently
from
53703b3 to
132282d
Compare
MaddTheSane
force-pushed
the
staticFuncs
branch
3 times, most recently
from
1f7857d to
414d521
Compare
static inlines excluded. Remove unused public declarations.
Fix a couple of compile errors.
Perhaps I shouldn't rebase when I'm sleepy.
Remember: compile, then commit.
...and this is why I marked this as a draft.
MaddTheSane
force-pushed
the
staticFuncs
branch
from
e7fcb58 to
2114a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This more aggressively marks functions and variables as static, as well as marking some values as
constexpr. Also included are a lot of comments, mainly remarking if a function is only used in one source file, or if it is unused in Descent 3 (and thus could probably be removed).Related Issues
This patch does incorporate changes from #346. These can be reverted.A recent rebase removed the DallasFuncs changes.Checklist
Additional Comments
Opened as a draft because this isn't complete, as well as wanting feedback about functions that aren't used by Descent 3 (either cut content incomplete features, or code that only used by the editor).