Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an Android build #459

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

tophyr
Copy link
Contributor

@tophyr tophyr commented Jun 24, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Adds Android as a supported platform. Uses Gradle to perform the build overall.

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

@Lgt2x
Copy link
Member

Lgt2x commented Jun 24, 2024

Just a suggestion... You can add the __LINUX__ define for android platforms instead of adding it to every check

@tophyr
Copy link
Contributor Author

tophyr commented Jun 24, 2024

Just a suggestion... You can add the __LINUX__ define for android platforms instead of adding it to every check

SDL specifically undefines __LINUX__ when ANDROID is defined, unfortunately.

.gitmodules Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Descent3/CMakeLists.txt Outdated Show resolved Hide resolved
Descent3/LoadLevel.cpp Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
android/proguard-rules.pro Show resolved Hide resolved
android/src/main/res/mipmap-hdpi/ic_launcher.png Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
scripts/data/fullhog/d3-android-fullhog.txt Show resolved Hide resolved
tools/CMakeLists.txt Outdated Show resolved Hide resolved
@tophyr tophyr marked this pull request as ready for review June 26, 2024 22:29
@tophyr tophyr force-pushed the android branch 3 times, most recently from 40bc996 to 142c739 Compare July 13, 2024 04:12
@tophyr
Copy link
Contributor Author

tophyr commented Jul 13, 2024

Ready for review.

Includes #493, #492, #469, and #465 as dependencies (see merge commit at base). Those PRs should be reviewed and merged prior to this one; marking this PR as a draft until then.

@tophyr tophyr marked this pull request as draft July 13, 2024 04:22
@tophyr tophyr force-pushed the android branch 2 times, most recently from bf7e6eb to 18169e5 Compare July 13, 2024 04:57
@tophyr tophyr requested a review from Lgt2x July 13, 2024 04:57
@Jayman2000 Jayman2000 mentioned this pull request Jul 17, 2024
13 tasks
@tophyr tophyr force-pushed the android branch 3 times, most recently from a5dc732 to 3d4601e Compare December 30, 2024 07:50
@tophyr tophyr marked this pull request as ready for review December 30, 2024 07:51
@tophyr tophyr mentioned this pull request Dec 30, 2024
13 tasks
@tophyr tophyr requested a review from pzychotic December 30, 2024 07:53
@tophyr
Copy link
Contributor Author

tophyr commented Dec 30, 2024

@Lgt2x this is finally ready! The game builds, has a mechanism to easily (and legally) put gamedata on the device, and will start up a level.

There's still a fair bit of work to do in order get the game playable, but at this point I think it's stable enough to start relying on build signals from GitHub CI.

Do note that this now PR includes the ExternalProject change from #465.

@tophyr tophyr force-pushed the android branch 5 times, most recently from 5165157 to fa99fa4 Compare December 31, 2024 18:35
@Lgt2x
Copy link
Member

Lgt2x commented Jan 1, 2025

Overall this is a pretty large and impactful port, I will need time before deciding whether to merge it. I especially want to make sure that I'm able to build, run and debug it, so I can independently fix the build if when it will break, with the goal of making it more sustainable. I'm not familiar at all with Java and Android, so wish me luck with that Android Studio thingy :)

@tophyr
Copy link
Contributor Author

tophyr commented Jan 1, 2025

Sounds like you've managed to build and run it, at least! Hit me up with any questions about this specifically or Android development in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants