Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cross-compiled ARM64 build #642

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

Lgt2x
Copy link
Member

@Lgt2x Lgt2x commented Oct 29, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Using the HogMaker build changes of #637 , introduce an example of cross-compilation to ARM64. This also serves as non-regression automated build for this type of compilation.

The changes to vcpkg.json are due to a VCPKG issue causing dbus cross-compilation to fail. The best solution would be to report the issue upstream to dbus, but for the time being, we simply disable the optional SDL2 dependency to dbus.

find_package(HogMaker) is now in top-level CMakeLists.txt, because otherwise the exported targets would not be found.

The changes

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@Lgt2x Lgt2x marked this pull request as draft October 29, 2024 20:00
@Lgt2x Lgt2x mentioned this pull request Oct 29, 2024
13 tasks
@Lgt2x Lgt2x force-pushed the arm64-cross branch 3 times, most recently from 1ae831d to 935dbc4 Compare October 29, 2024 20:13
@Lgt2x Lgt2x marked this pull request as ready for review October 29, 2024 20:14
Comment on lines 99 to 101
pushd builds/linux/
ninja -f build-${{ matrix.build_type }}.ninja HogMaker
popd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simpified with

ninja -f build-${{ matrix.build_type }}.ninja -C builds/linux/ HogMaker

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@winterheart winterheart merged commit 7fe52ec into DescentDevelopers:main Nov 29, 2024
12 checks passed
@Lgt2x Lgt2x mentioned this pull request Dec 27, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants