-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce cross-compiled ARM64 build #642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lgt2x
force-pushed
the
arm64-cross
branch
3 times, most recently
from
October 29, 2024 20:13
1ae831d
to
935dbc4
Compare
Due to a bug in DBUS and its VCPKG port VCPKG#40031, DBUS cannot be cross-compiled.
winterheart
reviewed
Nov 1, 2024
.github/workflows/build.yml
Outdated
Comment on lines
99
to
101
pushd builds/linux/ | ||
ninja -f build-${{ matrix.build_type }}.ninja HogMaker | ||
popd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simpified with
ninja -f build-${{ matrix.build_type }}.ninja -C builds/linux/ HogMaker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Using the HogMaker build changes of #637 , introduce an example of cross-compilation to ARM64. This also serves as non-regression automated build for this type of compilation.
The changes to
vcpkg.json
are due to a VCPKG issue causing dbus cross-compilation to fail. The best solution would be to report the issue upstream to dbus, but for the time being, we simply disable the optional SDL2 dependency to dbus.find_package(HogMaker)
is now in top-levelCMakeLists.txt
, because otherwise the exported targets would not be found.The changes
Checklist
Additional Comments