forked from iTowns/itowns
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing ESM migration #1
Open
Desplandis
wants to merge
2
commits into
master
Choose a base branch
from
migrate/esm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c65947
to
b61ce40
Compare
b7ac886
to
d084b9d
Compare
Pull Request Test Coverage Report for Build 8378462500Details
💛 - Coveralls |
9bc5763
to
04391f4
Compare
This includes: - all scripts under the docs repository (publish.js is loaded with require()) - all eslintrc config scripts (loaded with require()) - grunt/bump script (loaded with require()) - conventional changelog script (loaded with require()) - webpack.config
BREAKING CHANGE: The itowns library drops the CommonJS distribution in favor of a standard ECMAScript module (ESM) distribution.
b556f3f
to
a6b1052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
npm start
works