Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: selecting Compare from item popup in Compare panel will set new initialItemId #10861

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FlaminSarge
Copy link
Contributor

Text on button changes to New Compare when this will occur

Adding items to Compare session from main inventory now requires selecting Compare on Item Popup instead of being one click

First commit in this PR has the behavior of fully removing the existing compare session and starting a new one with the selected item.

… new session

Text on button changes to New Compare when this will occur
Adding items to Compare session from main inventory now requires selecting Compare instead of being one click
@bhollis
Copy link
Contributor

bhollis commented Dec 30, 2024

I can see that you no longer can add a matching item by just clicking on it - you have to click "Compare" or hit C. That's fine, though it may confuse folks used to the old workflow.

Hitting "Compare" on a non-matching item gives the same old error about not being comparable - it doesn't start a new compare session, and the label doesn't change. Am I missing something?

@bhollis bhollis requested a review from chainrez December 30, 2024 01:28
@FlaminSarge
Copy link
Contributor Author

FlaminSarge commented Dec 30, 2024

Hitting "Compare" on a non-matching item gives the same old error about not being comparable - it doesn't start a new compare session, and the label doesn't change. Am I missing something?

I don't think either of the two versions of this PR (first commit starting new session or second commit setting new initialItemId but preserving session) had this behavior, but I think it's worth adding as the behavior when selecting a non-matching item. I'm leaving this in draft until I can implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants