Skip to content

Commit

Permalink
update third-party
Browse files Browse the repository at this point in the history
  • Loading branch information
@Sak32009
Sak32009 committed Aug 18, 2024
1 parent 8d5c513 commit 0baf865
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion third-party/build/win
Submodule win updated from 07336f to 89d0bb
2 changes: 1 addition & 1 deletion third-party/common/linux
Submodule linux updated from ecaee3 to b4194b
2 changes: 1 addition & 1 deletion third-party/common/win
Submodule win updated from b7761d to a70c58
2 changes: 1 addition & 1 deletion third-party/deps/common
Submodule common updated from 1c1acc to 221977
2 changes: 1 addition & 1 deletion third-party/deps/linux
Submodule linux updated from 6cb47a to be0708
2 changes: 1 addition & 1 deletion third-party/deps/win
Submodule win updated from 6eb71e to 3171da

2 comments on commit 0baf865

@otavepto
Copy link
Contributor

@otavepto otavepto commented on 0baf865 Aug 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Detanup01 @Sak32009 repo can no longer be checked out recursively, this change just points the dev to a new commit id, but the actual third-party/ branches were not submitted with the original PR, you can even see it in the Files changed tab, making the dev now pointing at non-existent commits

I assume the third-party/ branches have some protection or something, you can also see for example third-party/build/win still points at the old commit id 07336fafed51cccbb1438bf32f90bb0d20634529 and the old archive is still there.

>> git submodule update --init --recursive

fatal: remote error: upload-pack: not our ref 89d0bbf43221dc758efa56f988cb0f0a34b84342
fatal: Fetched in submodule path 'third-party/build/win', but it did not contain 89d0bbf43221dc758efa56f988cb0f0a34b84342. Direct fetching of that commit failed.
Completed with errors, see above.

the line not our ref 89d0bbf43221dc758efa56f988cb0f0a34b84342 means the commit id 89d0b... used by the dev branch is invalid
the second line 'third-party/build/win', but it did not contain 89d0bbf43221dc758e... means the actual branch doesn't actually contain any commit with that ID

@Sak32009
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otavepto #15 #16 #17 #18 #19 #20 #21

Thanks for noticing that!

Please sign in to comment.