Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steam_HTTP::SendHTTPRequest()
where the ID of the triggered call-result from online requests was completely unrelated to the original request, resulting in timeoutSteam_HTTP::SetHTTPRequestHeaderValue()
where some games (like appid 1902490) set a cache-control policy which allows only responses from previous requests, otherwise the server will respond with error 504ISteamHttp
uselesssteam_http
where the buffer size wasn't set correctly resulting in a crashsteam_http
when downloading requests, this sounds scary, but otherwise the user has to load a local list of trusted certificates since mbedtls doesn't use the Trusted Authority list from Windows, also the option to download requests made by a game is disabled by defaultAs far as I can remember, this won't work with Github
I assume there might be a better way to handle this scenario but I just don't know how.
If you decided to integrate this PR, and it broke, you can ping me here and I'll see what broke and how to fix it.
You can test this with appid 1902490 (free game) since it downloads its own app schema via https protocol.
Feel free to close/reject this PR if it's too much trouble.