Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show github annotation on specific errors. #106

Merged
merged 10 commits into from
Feb 12, 2024
Merged

Show github annotation on specific errors. #106

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b6efc1c
Add some test stuff
Hoverbear Feb 9, 2024
8fe94da
Allow stuff
Hoverbear Feb 9, 2024
6be1761
Remove testing code
Hoverbear Feb 9, 2024
e2a221a
Add annotation for Conflict during error path as well.
Hoverbear Feb 9, 2024
8f02f1e
fmt
Hoverbear Feb 9, 2024
6b13c5f
Try a new way, with testing fixtures
Hoverbear Feb 9, 2024
2418ccc
Fmt
Hoverbear Feb 9, 2024
b1ad522
No multiline, sad.
Hoverbear Feb 9, 2024
a313710
Remove testing code again
Hoverbear Feb 9, 2024
261f5c1
Remove accidental double errors
Hoverbear Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,11 @@ async fn push_new_release(
revision = release_metadata.revision
);
if error_if_release_conflicts {
if std::env::var("GITHUB_ACTIONS").is_ok() {
// Output a Github Actions annotation
println!("::error title=Conflict::{upload_name}/{rolling_prefix_or_tag} already exists");
}

return Err(Error::Conflict {
upload_name,
rolling_prefix_or_tag,
Expand All @@ -734,6 +739,12 @@ async fn push_new_release(
StatusCode::UNAUTHORIZED => {
let body = &release_metadata_post_response.bytes().await?;
let message = serde_json::from_slice::<String>(body)?;

if std::env::var("GITHUB_ACTIONS").is_ok() {
// Output a Github Actions annotation
println!("::error title=Unauthorized::{message}");
}

return Err(Error::Unauthorized(message))?;
}
_ => {
Expand Down
Loading