Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-existent response body #147

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Handle non-existent response body #147

merged 5 commits into from
Jun 26, 2024

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented Jun 26, 2024

I'm currently getting this error in Gitlab:

Error: 
   0: expected value at line 1 column 1
Location:
   src/main.rs:125

The offending section: https://github.com/DeterminateSystems/flakehub-push/blob/main/src/main.rs#L123-L134

These changes should at least begin to unblock the as-yet-inscrutable issues here: https://gitlab.com/DeterminateSystems/testing/flakehub-push-test-subrepo/-/jobs/7194111999

src/main.rs Outdated Show resolved Hide resolved
@lucperkins lucperkins requested a review from cole-h June 26, 2024 15:48
@lucperkins lucperkins enabled auto-merge June 26, 2024 15:56
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@lucperkins lucperkins requested a review from cole-h June 26, 2024 16:28
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it worked for you

@lucperkins lucperkins merged commit 9f3d4ee into main Jun 26, 2024
6 checks passed
@lucperkins lucperkins deleted the response-body-handling branch June 26, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants