Fixup various issues with the nix.conf / nix.custom.conf split #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can place the "include" directive at the end of our standard config, allowing users to override our defaults.
colemickens
reviewed
Jan 15, 2025
colemickens
approved these changes
Jan 15, 2025
grahamc
reviewed
Jan 15, 2025
…ra-experimental-features` Otherwise, users may accidentally override our `experimental-features` default of `nix-command` and `flakes`. If a user truly wanted to override this, they can manually modify the `nix.conf` / `nix.custom.conf` after the install completes.
…nf _AND_ nix.custom.conf Cachix relies on the presence of this setting in the system `/etc/nix/nix.conf` so that it can provide users with a helpful error if `cachix use`ing a cache would not actually work for them (because only trusted users can modify the trusted caches and trusted cache signing keys in their user-specific configuration).
grahamc
approved these changes
Jan 15, 2025
grahamc
added
the
upload to s3
cole-h
force-pushed
the
fixup-config
branch
2 times, most recently
from
d441824 to
a0cd1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1389.
Fixes #1390.
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: