Problem running test in Jenkins CI #41
Comments
|
Hi @dgieselaar, that build was a very dirty fix. I just disabled closing of Browserstack tunnels after a test session, so it can't be used in production. Because I can't reproduce this behavior, I don't know what can I do to fix it. I guess if I could disable automatic tunnel creation and termination, it could work for such cases, but you would have to create a tunnel using |
|
What is the downside of this build? For us it's working fine, but I might have missed something. What particular lines need to be changed? I cannot find the source for the debug version. If I know where to look I can probably add some debugging statements that will help me fix it. |
|
Ah, it keeps the browserstack-local process open. I found various (possibly) related issues:
etc. Would you be open to a PR that accepts a env variable ( |
|
Thanks @dgieselaar, I think it's better to kill process if it doesn't close gracefully after some time. I think, 10 seconds must be enough for the timeout. |
|
@AndreyBelym Alright, would you want that (the killing of the process) in this library, or is it something that you think should be handled outside of this library? |
|
@dgieselaar yes, it must be implemented in the provider. It would be perfect if you could make a PR 😄 |
|
Will do!
…On Mon, May 28, 2018, 10:29 Andrey Belym ***@***.***> wrote:
@dgieselaar <https://github.com/dgieselaar> yes, it must be implemented
in the provider. It would be perfect if you could make a PR 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVh3O_LpD-4MXvHTnB4PToZPc-TZUBeks5t27VMgaJpZM4UFvOs>
.
|
|
This issue has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this issue in the future. If it still affects you or you have any additional information regarding it, please leave a comment and we will keep it open. |
|
We're closing this issue after a prolonged period of inactivity. If it still affects you, please add a comment to this issue with up-to-date information. Thank you. |
Hi,
Basically re-opening this issue: #14 (comment)
We have the same issue. The debug build (
1.1.1-git.201706070945) fixes it, but we'd like to upgrade to the latest version of the provider for better reporting.The text was updated successfully, but these errors were encountered: