Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The event objects wrongly wrapped #1277

Closed
LavrovArtem opened this issue Aug 24, 2017 · 2 comments
Closed

The event objects wrongly wrapped #1277

LavrovArtem opened this issue Aug 24, 2017 · 2 comments
Assignees
@LavrovArtem
Labels
AREA: client STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone
Sprint #9

Comments

@LavrovArtem
Copy link
Contributor

Take for example the message event:

// with hammerhead
JSON.stringify(event); // Uncaught TypeError: Converting circular structure to JSON
Object.keys(event); // ["isTrusted", "data", "origin",  ... and other 26 properties]

// without hammerhead
JSON.stringify(event); // "{"isTrusted":true}"
Object.keys(event); // ["isTrusted"]

related with #1276
@LavrovArtem LavrovArtem added this to the Planned milestone Aug 24, 2017
@LavrovArtem LavrovArtem self-assigned this Aug 24, 2017
@LavrovArtem LavrovArtem modified the milestones: Sprint #9, Planned Aug 25, 2017
@LavrovArtem
Copy link
Contributor Author

I'm working on this

LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Aug 28, 2017
@LavrovArtem
fix The event objects wrongly wrapped (close DevExpress#1277)
f22b87c
@miherlosev miherlosev mentioned this issue Aug 29, 2017
Merged
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@LavrovArtem @AndreyBelym
fix The event objects wrongly wrapped (close DevExpress#1277) (DevE…
c1e3f2e 
…xpress#1282)

* fix `The event objects wrongly wrapped` (close DevExpress#1277)

* fix tests

* fix review's issues
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LavrovArtem LavrovArtem

Labels
AREA: client STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Milestone
Sprint #9
Development

No branches or pull requests
1 participant
@LavrovArtem