Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is not ELEMENT_NODE #1465

Closed
miherlosev opened this issue Jan 31, 2018 · 3 comments
Closed

Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is not ELEMENT_NODE #1465

miherlosev opened this issue Jan 31, 2018 · 3 comments
Assignees
@miherlosev
Labels
AREA: client REGRESSION STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone
Sprint #10

Comments

@miherlosev
Copy link
Contributor

2147110

DevExpress/testcafe#2028
@miherlosev miherlosev added this to the Sprint #10 milestone Jan 31, 2018
@miherlosev miherlosev self-assigned this Jan 31, 2018
@miherlosev
Copy link
Contributor Author

I'm working on this

@miherlosev miherlosev changed the title Should not omit text nodes for Element.nextSibling Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is TEXT_NODE Jan 31, 2018
miherlosev pushed a commit to miherlosev/testcafe-hammerhead that referenced this issue Jan 31, 2018
fix 'Should perform 'isShadowUIElement' checking for 'Node.nextSiblin…
81e47de 
…g' when Node is TEXT_NODE' close (DevExpress#1465)
@miherlosev miherlosev changed the title Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is TEXT_NODE Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is not ELEMENT_NODE Jan 31, 2018
miherlosev added a commit that referenced this issue Feb 1, 2018
@miherlosev
fix 'Should perform 'isShadowUIElement' checking for 'Node.nextSiblin…
b3e6f94 
…g' when Node is TEXT_NODE' close (#1465) (#1466)

* fix 'Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is TEXT_NODE' close (#1465)

* fix tests

* fix tests (2)
@miherlosev
Copy link
Contributor Author

Fixed in #1466

AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@miherlosev @AndreyBelym
fix 'Should perform 'isShadowUIElement' checking for 'Node.nextSiblin…
bcc75b4 
…g' when Node is TEXT_NODE' close (DevExpress#1465) (DevExpress#1466)

* fix 'Should perform 'isShadowUIElement' checking for 'Node.nextSibling' when Node is TEXT_NODE' close (DevExpress#1465)

* fix tests

* fix tests (2)
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miherlosev miherlosev

Labels
AREA: client REGRESSION STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Milestone
Sprint #10
Development

No branches or pull requests
1 participant
@miherlosev