Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use a stored 'innerHTML' property setter for Node #1538

Closed
miherlosev opened this issue Mar 20, 2018 · 1 comment
Closed

Should use a stored 'innerHTML' property setter for Node #1538

miherlosev opened this issue Mar 20, 2018 · 1 comment
Assignees
@LavrovArtem
Labels
AREA: client !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone
Sprint #11

Comments

@miherlosev
Copy link
Contributor

miherlosev commented Mar 20, 2018 •
edited
Loading

See https://testcafe-discuss.devexpress.com/t/the-page-under-test-is-not-loading-because-of-hammerhead-js-issue/960.

Code for reproduce

<html>
	<body>
		<script>
			Node.prototype.__defineSetter__("innerHTML", function(s) {
				throw 'Don\'t use "innerHTML"';
			});
			
			var div = document.createElement('div');
			
			div.innerHTML = '<span>Text in div</span>';
		</script>
	</body>
</html>

Part of #1379.

@LavrovArtem
Next property for rewriting - innerHTML.
@miherlosev miherlosev added this to the Sprint #11 milestone Mar 20, 2018
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Mar 22, 2018
@LavrovArtem
Remove unnecessary code which sets the innerHTML property to a docume…
24a2fbc 
…nt fragment (close DevExpress#1538)
@miherlosev miherlosev mentioned this issue Apr 11, 2018
Closed
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@LavrovArtem @AndreyBelym
Remove unnecessary code which sets the innerHTML property to a docume…
ce15f41 
…nt fragment (close DevExpress#1538) (DevExpress#1542)

* Remove unnecessary code which sets the innerHTML property to a document fragment (close DevExpress#1538)

* test refactoring
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LavrovArtem LavrovArtem

Labels
AREA: client !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Milestone
Sprint #11
Development

No branches or pull requests
2 participants
@miherlosev @LavrovArtem