A proxied request hangs if a request to the original site emits an error

[AndreyBelym]

I don't know if this can be reproduced in production, but likely it can.

Take a looks at the error handlers of the DestinationRequest's req object:

_onError at src/request-pipeline/destination-request/index.ts

    _onError (err: Error): void {
        if (this._isSocketHangUpErr(err))
            this.emit('socketHangUp');

        else if (requestAgent.shouldRegressHttps(err, this.opts)) {
            requestAgent.regressHttps(this.opts);
            this._send();
        }

        else if (this._isTunnelingErr(err)) {
            //...
        }

        else if (this._isDNSErr(err)) {
            //...  
        }

        else
            this.emit('error', err);
    }

error at src/request-pipeline/utils.ts

    req.on('error', () => {
        ctx.hasDestReqErr = true;
        resolve();
    });

If an error can't be handled by any brach in the _onError handler, it will be handled by the generic error handler, that just sets the ctx.hasDestReqErr and doesn't set the ctx.goToNextStage flag. After that the first flag is not handled by any code because without the second request pipeline silently terminates here just after the request is resolved.

How to reproduce:

1. (optional) Add logging statements or breakpoints:
   test/playground/server.js:24
   src/request-pipeline/index.ts:210
   src/request-pipeline/utils.ts:95
   src/request-pipeline/destination-request/index.ts:171

2. npm i nock

3. Create test.js:

const nock = require('nock');
const playground = require('./test/playground/server');

nock('http://example.com')
    .get('/')
    .replyWithError('this fails')
    .persist();

playground.start();

3. node test.js
4. When a browser opens, open DevTools.
5. Proxy example.com.
6. Request to the proxied page started and never finishes, no error is logged in handlePageError at test/playground/server.js

[gal432]

I think that is what I am dealing with in this ticket

[gal432]

any updates about the problem?

[AlexSkorkin]

No updates yet. You will be automatically notified once we make progress.

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.