fix The XhrSandbox.openNativeXhr function calls non native the xhr.setRequestHeader function (close #1252)
#1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etRequestHeader function` (close DevExpress#1252)
|
❌ Tests for the commit ff3128e have failed. See details: |
|
❌ Tests for the commit f4bcdb9 have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit f4bcdb9 have passed. See details: |
miherlosev
suggested changes
Aug 3, 2017
| @@ -17,6 +17,13 @@ QUnit.testDone(function () { | |||
| iframeSandbox.off(iframeSandbox.RUN_TASK_SCRIPT_EVENT, initIframeTestHandler); | |||
| }); | |||
|
|
|||
| function findPrototypeWithProp (obj, prop) { | |||
There was a problem hiding this comment.
getPrototypeFromChainContainsProp (obj, prop)
| @@ -43,6 +50,23 @@ test('createNativeXHR', function () { | |||
| ok(xhr instanceof nativeMethods.XMLHttpRequest); | |||
|
|
|||
| window.XMLHttpRequest = nativeMethods.XMLHttpRequest; | |||
|
|
|||
| var isWrappedFunctionRE = /^return 'function wrapped'$/; | |||
There was a problem hiding this comment.
var isWrappedFunctionRE = /^return 'function is wrapped'$/;
|
✅ Tests for the commit 150eabb have passed. See details: |
miherlosev
approved these changes
Aug 3, 2017
AlexanderMoskovkin
approved these changes
Aug 3, 2017
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…etRequestHeader function` (close DevExpress#1252) (DevExpress#1254) * fix `The XhrSandbox.openNativeXhr function calls non native the xhr.setRequestHeader function` (close DevExpress#1252) * fix test * test refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @miherlosev @churkin