Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the composed property to events (closes #4739 in TestCafe) #2262

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

AlexKamaev
Copy link
Contributor

@AlexKamaev AlexKamaev commented Mar 5, 2020

This is the fix for https://github.com/DevExpress/testcafe/issues/4739

The click event should propaganate throught shadowDom boundaries, but it does not, since we do not mark our events as composed .

Here is the explanation from MDN:

The read-only composed property of the Event interface returns a Boolean which indicates whether or not the event will propagate across the shadow DOM boundary into the standard DOM.

https://developer.mozilla.org/en-US/docs/Web/API/Event/composed

I prepared the list of composed events from the specs:
https://www.w3.org/TR/uievents/

I cheched all events from the list, that they really bubbles through the shadowDom

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 9f601f3 have passed. See details.

@AlexKamaev AlexKamaev changed the title [WIP]add the composed property to events (closes #4739 in TestCafe) add the composed property to events (closes #4739 in TestCafe) Mar 5, 2020
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 3f5718d have passed. See details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants