add the composed
property to events (closes #4739 in TestCafe)
#2262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for https://github.com/DevExpress/testcafe/issues/4739
The click event should propaganate throught shadowDom boundaries, but it does not, since we do not mark our events as
composed
.Here is the explanation from MDN:
https://developer.mozilla.org/en-US/docs/Web/API/Event/composed
I prepared the list of
composed
events from the specs:https://www.w3.org/TR/uievents/
I cheched all events from the list, that they really bubbles through the shadowDom