fix Server shutdown with "Error: Can't set headers after they are sent." (close #937)
#940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 0415c72 have failed. See details: |
LavrovArtem
force-pushed
the
issue-937
branch
from
0415c72 to
9202cba
Compare
inikulin
suggested changes
Nov 15, 2016
| @@ -112,8 +112,11 @@ export default class DestinationRequest extends EventEmitter { | |||
| this._send(); | |||
| } | |||
|
|
|||
| else if (this._isDNSErr(err)) | |||
| else if (this._isDNSErr(err)) { | |||
| this._abort(); | |||
There was a problem hiding this comment.
It makes sense to refactor whole code into method:
_fatalError(msg) {
this.aborted = true;
this.req.abort();
this.emit('fatalError', getText(msg, this.opts.url));
}Remove _abort and use _fatalError everythere
There was a problem hiding this comment.
@inikulin thanks, good idea
|
❌ Tests for the commit 9202cba have failed. See details: |
LavrovArtem
force-pushed
the
issue-937
branch
from
9202cba to
44ae145
Compare
|
❌ Tests for the commit 44ae145 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 44ae145 have failed. See details: |
|
@testcafe-build-bot \retest |
LavrovArtem
force-pushed
the
issue-937
branch
from
44ae145 to
47aa1a4
Compare
|
✅ Tests for the commit 47aa1a4 have passed. See details: |
|
FPR |
|
ping @inikulin |
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @churkin @miherlosev